Raise error for PennyLaneDeprecationWarning in rc tests #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can discuss with @Alex-Preciado and @christianbmadsen but I think it would be better for the Braket tests on PennyLane latest to not treat deprecation warnings as errors, because it could cause us to miss more important failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Braket tests are passing vs the RC branch (but not PennyLane latest) because the RC tests don't mark the deprecation warnings as errors.
This adds the same line we have in the standard test matrix tests to the RC tests, so they will mark it as an error if there is a
PennyLaneDeprecationWarning